Martin Charles

Results 63 comments of Martin Charles

Ok, I think this is ready for another look. Some things to note: 1. Is a closure which is `'static` and `Sync` more useful than a function pointer? When I...

Thanks for the feedback, I appreciate the upfront time investment reviewing these PRs while sharing information. I plan to continue to make contributions to this project. I appreciate you taking...

done! fwiw, there is a button in github which allows owners to squash the commits how they see fit. https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests

This could be implemented client side with wasm!

This still occurs for me in the latest version of rust rover, it is very annoying to read code and see false positives on almost every line. Using version of...

I have a similar use case too. I got it working with tonic (codgen and all) here. https://github.com/hyperium/tonic/pull/1789

The code is heavily commented. It looks like doxygen or JavaDoc. If I can figure out what syntax it is in I could build the documentation. Until then, you could...

It seems that google only sees the landing page. This could probably be fixed by using Links instead of history.push