Felix Matouschek

icon indicating a website link matouschek.org icon indicating an email [email protected]

icon company Red Hat icon location Germany icon location Software Engineer passionate about open source software and currently working on KubeVirt. In my spare time I'm tinkering on all sorts of devices and software.

Results 273 comments of Felix Matouschek

[WIP] cleanup(tests,memorydump): Move virtctl related tests

@ShellyKa13 I don't necessarily disagree to keep some of the tests, but I also have some concerns. > creation of the pvc [...] is done properly What does this mean?...

[WIP] cleanup(tests,memorydump): Move virtctl related tests

@mhenriks Agree, I'll update this PR to do that.

[WIP] cleanup(tests,memorydump): Move virtctl related tests

@ShellyKa13 PTAL again, does this look acceptable to you?

ci: periodic pipeline can perform a dry run of the promote step

Is it because we can't have a single pipeline that builds and **tests** all artifacts for a given containerdisk Entry?

add openSUSE Leap 16 handling

/release-note-none

virtctl create vm cleanups

/retest-required

virtctl create vm cleanups

/cherry-pick release-1.4

virtctl create vm cleanups

/retest

fix(instancetypes): Protect instancetype/preference `controllerRevision` objects

I don't see benefit in contrast to the added complexity. We should not be protecting CRs at all. Why is it not enough to clear either `spec.instancetype.revisionName` or `spec.preference.revisionName` before...

fix(instancetypes): Protect instancetype/preference `controllerRevision` objects

> isn't it a generic problem, independently from the deletion protection, that a controller revision of a instancetype/preference can be deleted before the related VM is deleted? This is a...