Felix Matouschek
Felix Matouschek
Thanks for creating the VEP. Let's see if we can update it so it follows VEP100 more closely. However, I'm unsure if we can still make it in time for...
I added some more questions to the VEP. 1.9 sound appropriate to me, so let's wait a little longer.
That is indeed a problem. Perhaps a remnant of the libvmi that was born in `/tests`. Perhaps we can remove `WithTerminationGracePeriod` from here: https://github.com/kubevirt/kubevirt/blob/95d4798fdaa1a4e421c9077d0b8692af56c5491c/pkg/libvmi/vmi.go#L41 And add it here instead: https://github.com/kubevirt/kubevirt/blob/85e36ff363013c43fa4856b4fa774615363882dd/tests/testsuite/fixture.go#L161...
Can you squash the commits, please?
Thanks! /test all
Click on the details link of one of the failed jobs. It's complaining about uncommitted changes. You need to run `make generate` and add the changes to your commit.
/test pull-kubevirt-generate
/cc @fossedihelm