containerdisks icon indicating copy to clipboard operation
containerdisks copied to clipboard

ci: periodic pipeline can perform a dry run of the promote step

Open nestoracunablanco opened this issue 6 months ago • 4 comments

This approach allows for code reuse, enabling testing of different architectures without the need to promote changes.

Release note:

NONE

nestoracunablanco avatar May 08 '25 13:05 nestoracunablanco

Can you give an example set of commands that this helps with?

Sure, when we run it using the environment variable PROMOTE_DRY_RUN=true, it allows us to periodically run tests for other architectures without needing to publish anything. A valid use case could be to run tests for ARM and s390x with this option, and if everything goes well, run tests for AMD64 and publish the images.

There is also a PR in the pipeline for project-infra, which will be opened for discussion if this change is approved.

What do you think?

nestoracunablanco avatar May 12 '25 13:05 nestoracunablanco

Is it because we can't have a single pipeline that builds and tests all artifacts for a given containerdisk Entry?

0xFelix avatar May 13 '25 10:05 0xFelix

Yes, the issue is that kubevirtci, with its default parameters, starts a Kubernetes cluster on the same machine. This means that only one architecture can be tested without complicating the code. This setup could allow for periodic jobs for other architectures that do not publish images.

nestoracunablanco avatar May 13 '25 12:05 nestoracunablanco

/retest

nestoracunablanco avatar Jun 17 '25 08:06 nestoracunablanco

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot avatar Jun 23 '25 11:06 kubevirt-bot

@akrejcir what do you think about this change?

nestoracunablanco avatar Jun 26 '25 09:06 nestoracunablanco

/lgtm

akrejcir avatar Jul 08 '25 12:07 akrejcir