Gihwan Kim

Results 10 comments of Gihwan Kim

I'm interested in this issue. > Think about the ways to expose compression options such as level. I think that we can provide an option like `CompressionType` that has `ZSTD`,...

Thank you!!! May I try to send a PR?

Oh, I was being ambiguous. > What do you think of sending a PR for this first? This is what I also intended. Let me prepare!

I agree that disabling by default has a risk. I think that keeping the default behavior and providing an option to control would be better so that users can take...

I see, I misunderstood the intention. I took a conservative approach: there might be a risk that I could not imagine. I couldn't imagine any risk.

~~Additionally, how do you think similar feature, `HttpRequest.ofJson`?~~ Additionally, how about adding `HttpRequest.ofJson` also?

Hi @jjlin I've updated all tables in the mod page. PTAL.

> As you mentioned, RecordFieldSetMapper works with a Kotlin data class so Kotlin users can just set that mapper or a custom one directly. You makes sense. But when both...

> Is there a reliable way to detect that? I've filled an issue to spring-framework about providing a way to detect a Kotlin data class. https://github.com/spring-projects/spring-framework/issues/32937

> Improve DocService to reconfigure itself on server configuration changes. ServerListener will need additional life cycle callbacks, e.g. routeAdded, routeRemoved. `routeAdded`, `routeRemoved` look useful for `HealthCheckService` also. At this moment,...