golang
_content: add styles for mod table
Make Environment variables table readable: align table cell to top and add border between rows.
Fixes golang/go#67368
This PR (HEAD: 8844d82d6ddbbc2bcf82f3c8e400891fea0db131) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/website/+/592955.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. After addressing review feedback, remember to publish your drafts!
Message from Gihwan Kim:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. After addressing review feedback, remember to publish your drafts!
@0x1306e6d I wasn't able to add this comment on Gerrit for some reason:
While I opened the bug for the environment variables table in particular, every table in the same page is affected (there are quite a few if you search for <table), so it would be good to fix those too.
I'm not sure if other pages in the Go docs are similarly affected. I sampled a few other prominent doc pages, but based on those, it doesn't seem like tables are used often in general.
This PR (HEAD: 7646862bdc917cd8dee7adf5a0ae70dc179e7457) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/website/+/592955.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Sean Liao:
Patch Set 3: Auto-Submit+1 Code-Review+2 Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 3:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-04-12T12:12:48Z","revision":"f96b119089f5324a7d3aa8bb5890a99f4dcd7f1b"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 3: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 3:
This CL has failed the run. Reason:
Tryjob golang/try/x_website-gotip-linux-amd64-boringcrypto has failed with summary (view all results):
- go on master (commit 21acfdc) / website on master (change 592955)
To reproduce, try gomote repro 8717794853685952609.
Additional links for debugging:
Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 3: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 4:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-04-12T12:27:33Z","revision":"cac1ad0ab12366c2f35714a72e552a166108f696"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 4: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 4:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 4: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. After addressing review feedback, remember to publish your drafts!
Message from Michael Pratt:
Patch Set 4:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 4: -Code-Review
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. After addressing review feedback, remember to publish your drafts!
Message from Michael Pratt:
Patch Set 4:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/592955. After addressing review feedback, remember to publish your drafts!