06393993
06393993
> Looks generally great, just a few more comments. Could you let me know within the next day or so whether you'll have time to get this finished up? If...
`cargo nextest run --workspace` seems to want to execute the `C:\src\rust-test\target\debug\deps\hello_macro-621f285b4f25d626.exe` binary which depends on `std-49e3d1aefc00cc02.dll` installed under `$RUSTUP_HOME/toolchains/stable-x86_64-pc-windows-msvc/bin`, but is not available in the DLL search path.
> Are you using rustup-installed cargo? Yes, exactly. > I'd love it if you were interested in fixing this! Let me check the details and decide whether I will have...
Actually I can't even run test for nextest ``` note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace FAIL [ 16.921s] integration-tests::integration test_run_after_build --- STDOUT: integration-tests::integration test_run_after_build --- running...
The following patch will fix the issue for me on my machine: ``` PS C:\src\nextest> git diff diff --git a/nextest-runner/src/list/test_list.rs b/nextest-runner/src/list/test_list.rs index 8ae64c76..54ee1ad9 100644 --- a/nextest-runner/src/list/test_list.rs +++ b/nextest-runner/src/list/test_list.rs @@ -478,6...
After going over the code base, my plan is: 1. add the path of `$(rustc --print sysroot)` to `BuildPlatforms` 2. create a new `BuildPlatformsSummary` to replace `PlatformSummary`, which includes both...
> Appears that some of the previous review comments weren't addressed. Maybe you forgot to push the final version? Github UI hides those comments by default, and sorry I didn't...
* On https://github.com/jj-vcs/jj/pull/6728#discussion_r2212897126, just wondering, have we considered https://rust-lang.github.io/rustfmt/?version=v1.8.0&search=#reorder_imports? * On https://github.com/jj-vcs/jj/pull/6728#discussion_r2212891794, do we want to add typo check in our CI?
The example implementation is at https://github.com/06393993/jj/compare/gitattr-design...gitattr-design-wip-alt.
> @06393993 any desire to continue? Yes, but I don't have much time right now, and I don't recieve too many of review yet. Probably because I didn't push the...