06393993

Results 38 comments of 06393993

@yuja before I start to work on this feature, do we agree that we really want more EOL conversion related features in `jj`, especially the `text` `gitattributes` and the `eol`...

Hi all, I think this design is ready for review. Please comment on the questions left in the Open questions section if you have opinions to those questions. I will...

TODO after this change is merged: - [ ] File an issue for gitattributes diff support. - [ ] File an issue for gitattributes merge support. - [ ] File...

> Both of these proposed solutions seem to have the effect of hiding the provenance issue rather than trying to address it. The latter is probably outright UB because you're...

> Could you back them with a real memory allocation, and transmute from a pointer rather than using from_raw? Thanks. transmute does work. > Maybe from_raw should ultimately accept a...

Do we care to change the `as_raw` to return `*mut u8` for consistency or potential dereference use case as well? I personally don't think we should do that. Dereferencing the...

A trait method is specifically useful, because my use case tries to handle all the dispatchable object. However, I don't feel strong on it, as I can definitely work around...

Sure, thanks. I have revised the PR because a new interface at least help me get rid of unnecessary `unsafe` `transmute_copy`. Let's wait for the final decision then.