Petr Pokorny

Results 70 comments of Petr Pokorny

Just tried this and it reproduced for me as described.

I didn't really dig deep into this, but both _Rename_ and _Find all references_ use `SymbolHelpers.getSymbolUsesInProjects` as far as I can tell. Also give the same results for the repro...

That's correct, you can't have multiple `X`s in a single expression. It would probably be possible to add this functionality, but it hasn't been implemented. You can take a stab...

> In terms of why I want to get this fix in: > > [...] Wow all of that because of the extra `FSharpOptions` 😲 Or did you tweak the...

When opening the solution in VS I get: ![image](https://github.com/dotnet/fsharp/assets/217092/0fdfe0cd-f797-493c-9acd-74428cec0bdb) Output Window says: `Some of the properties associated with the solution could not be read.` But `Gallery/Root/State.fs` seems to work fine,...

Any changes to this behavior should go through language suggestions. See https://github.com/fsharp/fslang-design/blob/main/FSharp-6.0/FS-1108-undentation-frenzy.md for examples. We might want to look into improving the error messages somehow.

To be fully correct I think we should not be raising OCE at all in the 6 cases here https://github.com/dotnet/fsharp/blob/315966454bcd4e0ec273fa2ab70bcbc48cdbcb86/vsintegration/src/FSharp.Editor/LanguageService/WorkspaceExtensions.fs Because VS does not expect us to be canceling anything...