Arseny Kapoulkine

Results 305 comments of Arseny Kapoulkine
trafficstars

You’d still need cgltf_free; it’s easier to forget in code like above. With that it doesn’t seem like ergonomics is any better, and cgltf allocates enough that one extra allocation...

One subtlety that this is missing from #228 is cgltf_accessor_read_float / cgltf_accessor_unpack_floats. These should continue to use 32-bit float types, one because glTF data contained in accessors can't be double...

Also cgltf_write's CGLTF_DECIMAL_DIG constant probably needs to be updated here.

Yeah cgltf.h needs something like ``` #ifndef _CRT_SECURE_NO_WARNINGS #define _CRT_SECURE_NO_WARNINGS #endif ``` in its implementation section. This won't fully help if cgltf.h is compiled as part of a .cpp file...

cgltf will parse files with Draco data, but it doesn't have the automatic decompression integrated; similarly to EXT_meshopt_compression, you need to integrate Draco library, and give it the byte stream...

Alternatively we could also remove `volk.c` from the install target list and add a separate option, like `VOLK_INSTALL_SOURCE`, that adds it back. I'm fine with either option - I'd probably...

This runs into a problem with `vkGetDeviceProcAddr` - it's an instance method so it's only loaded by `volkLoadInstance`, and without this `volkLoadDeviceTable` doesn't actually work because it relies on this...

`vkGetInstanceProcAddr`, `vkCreateInstance`, `vkEnumerateInstanceExtensionProperties`, `vkEnumerateInstanceLayerProperties`, `vkEnumerateInstanceVersion` would need to still be loaded as globals (volk calls them "loader functions"). volk could provide `VolkInstanceTable` struct & `volkLoadInstanceTable` function for other instance functions...

@ilyas-taouaou let me know if the API in #154 will work for you.

Ah, nice! I didn't realize this is available as a transform since it wasn't exposed as a CLI argument. I'm personally fine with running a script but I do want...