Georg Semmler comments

Results 614 comments of


                                            Georg Semmler

Upsert with where clause Postgres implementation is wrong

This report does not describe an actual bug, but it's a feature request as it seek to add new functionality. The `WHERE` clause in this position is valid and shouldn't...

Upsert with where clause Postgres implementation is wrong

@mohe2015 Yes that was not planed. Seems like github interpreted "Revert "Fix #3330"" as action to close this issue 🤦

Wrong documentation around sqlite datetime / inference not taking tz into account

> The FromSql to ToSql traits are only implemented for TimestamptzSqlite for OffsetDateTime. This is correct. The documentation is wrong there and needs to be changed. PR's welcome. > Which...

Wrong documentation around sqlite datetime / inference not taking tz into account

> The only annoying thing with the name currently is that you have to import in the generated schema file, you can't just type TimestamptzSqlite (though Timestamptz is available if...

Insertable derive macro causes struct properties to fail to compile with `error: unnecessary qualification` error when `-Dunused_qualifications` rustc flag used

There is unfortunately no ways for proc-macros to check for items in scope. Therefore we need to always generate fully qualified references to types/traits/.... Additionally as `unused_qualifications` is an allowed...

Insertable derive macro causes struct properties to fail to compile with `error: unnecessary qualification` error when `-Dunused_qualifications` rustc flag used

It might or it might not. As pointed out above: I personally do not want to invest my time here, so feel free to try it. I accept any solution...

Insertable derive macro causes struct properties to fail to compile with `error: unnecessary qualification` error when `-Dunused_qualifications` rustc flag used

@mikemcdermottredjack The relevant generation code is here: https://github.com/diesel-rs/diesel/blob/9502a9fd3df61bcfd59c63fecb79e242802e99d6/diesel_derives/src/insertable.rs#L117 You can just add a `#![deny(unused_qualifications)]` here to test whether the fix works or not: https://github.com/diesel-rs/diesel/blob/9502a9fd3df61bcfd59c63fecb79e242802e99d6/diesel_derives/tests/insertable.rs#L1

Insertable derive macro causes struct properties to fail to compile with `error: unnecessary qualification` error when `-Dunused_qualifications` rustc flag used

@mikemcdermottredjack That's unfortunately not possible as this would break usecases where the derive is used in a scope containing some other item named `Option`. So for example it would break...

Insertable derive macro causes struct properties to fail to compile with `error: unnecessary qualification` error when `-Dunused_qualifications` rustc flag used

As pointed out quite a few times before: It's not a priority to provide a fix for this for me. I will accept a PR for this, but won't write...

Add ability to serialize additional fields to the MigrationMetadata

I would prefer not adding any additional dependency to `migration_internals` and not to use `serde_json::Value` as "stringly" typed value type there. That written: I can see use cases for such...