Lee *!* Clagett

You commented on this - but to highlight to everyone - The primary issue is that this leaks the origin (or re-broadcaster) to all connected ZMQ clients, but does not...

[Ctrl-c is disabled during password prompt](https://github.com/monero-project/monero/blob/master/src/simplewallet/simplewallet.cpp#L10213). The actual issue was a thread joining itself and other weird shutdown issues. There was something funky about readline too. You can scroll through...

Please provide more information, is this for performance increase, code clarity, or? This is going to be a big review for everyone else.

Can you at least tell me (even privately) what bugs this is fixing? Otherwise this is possibly a re-write for clarity sake, bordering on a re-write to meet your favored...

> Did you try to run added tests from the first commit ? Yes, I can read the tests, but was a re-write the best way to fix these issues?...

Also note that this is going directly into the master branch, and not the dev branch.

@fluffypony With semantic versioning, I assume you meant at the hardfork level (as opposed to HTTP-RPC or P2P layer)? So a major version change indicates a hard-fork, whereas a minor...

BTW - I'm interested in this topic because I decided to "mirror" version numbers for `monero-lws`. So I've been wondering how this would play out because it meant that the...

I find the concept of a hash-based bin selection interesting, because assuming the algorithm is reproducible across CPUs(!), the transaction size should be much smaller than listing each ring member....

> The key to this is defining a floating output selection zone (constants BINNING_UPPER_BOUND_SELECTION_WIDTH and MIN_ALLOWED_WIDTH_FLOATING) that doesn't give away information in most cases. "in most cases" is not a...