Lee *!* Clagett
Lee *!* Clagett
Another rebase with a switch to `std::optional` since we are on C++17 now. Also updated how `params` in `json_rpc` is handled, to match recent bug fixes.
`basic_value` is used by JSON-RPC `id` field, and no one where else currently.
@jeffro256 Earlier I mentioned protobuf, and I forgot completely that this interface cannot support reading of protobuf arrays (without some modifications to the interface). Write support should be possible (although...
@jeffro256 I finally updated this PR. I thought it was done previously, but I didn't merge in the requested changes for the read interface. Changes: * Rebased * Changes requested...
Rebased (although technically not needed), and merged changes from other review (due to rebasing changes).
As a clarification - is this a race condition on the txpool? If the tx is already in the pool, it shouldn't re-relay it. But this should be possible if...
I keep forgetting about that limit. This fix (once corrected) should keep the connections alive from what I've seen (just re-reviewed the tx relay code).
Can this be re-opened on the `develop` branch? I'll then backport to `master` and `release-v0.3_0.18` branches.
Nevermind, I see this was done mainly as an example. I'm not sure if the default behavior should be to do another disk I/O to change state into active. The...
You can do that now with `tx_extra`. Use the existing ECDH+hash as the shared-key, and then encrypt and stash into `tx_extra`.