Vladimir Sitnikov

Results 998 comments of Vladimir Sitnikov

Ok, my question is (it is exactly as in https://github.com/ec4j/ec4j/issues/116#issuecomment-680764321 ) Supose I have the following file structure: ``` .editorconfig

That is the issue I mention: `encoding to use to read .editorconfig files` should be a property of `EditorConfigLoader` rather than a property of `Resource` or `ResourcePath`. `Resources.ofPath(Paths.get("src/main/test.xml"), editorConfigEncoding)` looks...

I tried `latest.integration` and it does not resolve the case for me: ```java private static final AtomicReferenceFieldUpdater CANCEL_TIMER_UPDATER = AtomicReferenceFieldUpdater.newUpdater( PgStatement.class, TimerTask.class, "cancelTimerTask"); ``` still converts to ```java private static...

For the reference, I used the following workaround: ```java @SuppressWarnings("RedundantCast") // Cast is needed for checkerframework to accept the code private static final AtomicReferenceFieldUpdater CANCEL_TIMER_UPDATER = AtomicReferenceFieldUpdater.newUpdater( PgStatement.class, (Class) TimerTask.class,...

The code is here: https://github.com/pgjdbc/pgjdbc/pull/2979 `./gradlew rewriteRun`

If that matters, I use javac 17 and target 8

Did you consider adding tests for the change?

`char* key` and `char* value` would be visible as well. However, they will be much easier to generate and parse. For instance, binary encoding would not need escape processing which...