jmeter icon indicating copy to clipboard operation
jmeter copied to clipboard

Fix the wrong throughput of the ConstantThroughputTimer

Open onionzz opened this issue 1 year ago • 2 comments

Description

Fix #6278

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [ ] My code follows the code style of this project.
  • [ ] I have updated the documentation accordingly.

onionzz avatar May 20 '24 10:05 onionzz

Did you consider adding tests for the change?

vlsi avatar May 20 '24 18:05 vlsi

I think the current implementation of ConstantThroughputTimer does not allow for really high throughput timing, as it relies on the timer resolution for sleep, which is milliseconds.

If we want to go for higher resolution, we would have to add more state, to allow now sleeping, when we expect to have more than one sampler in one millisecond.

FSchumacher avatar Sep 27 '24 08:09 FSchumacher