Vladimir Sitnikov

Results 998 comments of Vladimir Sitnikov

#77 is an approach to estimate "which files were changed", however, it does not solve the case when its dependency changes (see https://github.com/openrewrite/rewrite-gradle-plugin/issues/256#issuecomment-1886432944 regarding `DefaultImplementation` example)

>Just to be sure: are you running from the root of the repository? In Gradle model, it should not matter. `project.file("rewrite.yml");` does not use "current working directory" but it resolves...

> for better API use such as 3, proper validation and warning as mentioned in 2 Could you please clarify what you mean by "use API 3"?

https://docs.openrewrite.org/reference/gradle-plugin-configuration#multi-module-gradle-projects says the plugin can be applied to individual projects. > When applied to a multi-project build, plugin behavior differs depending on whether the plugin is applied to the root...

> OpenRewrite also doesn't have access to the TaskContainer#register methods due to attempting to keep a low point of entry for all users (OSS and Enterprise) of 4.0 Have you...

> By default OpenRewrite begins with a Intellij style ... > Whether that failed to load is a warning message or a terminal error, I do not know. Well, user...

WDYT of generating a class with the compile-time constants?

I can replicate something like https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/main/version/org/postgresql/util/DriverInfo.java

The question is how the default caching should work. It would be weird if every signing would require TUF update. On the other hand, if we claim `$HOME/.sigstore-java/caches/tuf`, then we...

I incline it might be easier to start by committing everything together (e.g. merge bundle into sigstore-java), and then try moving classes around to see if they really split :)