Vladimir Sitnikov

@qizhou92 , thanks for the PR. > I am not quite sure how much code I should push in commit to reviewing That differs on a case-by-case basis. For z3...

@qizhou92 , this looks nice. Have you seen `RexFuzzer`, `RexProgramFuzzyTest`, `org.apache.calcite.rex.RexSimplify#verify` ? I wonder if `z3` verifications could be integrated to `RexSimplify#verify`. Of course, it would be limited to `int`...

I guess we want to keep RexImplicationChecker, so we don't want to use slow approaches like z3 there. On the other hand, z3 might be helpful for testing RexImplicationChecker.

>but what is the time requirement in general for checking RexNode implication, like ~10 milliseconds? ~1 milliseconds? ~0.1 milliseconds? Just want to get a sense. The expectation is that both...

@julianhyde , Could you please refrain from adding `@Nonnull`? It should be a default mode, so there's no point in adding `@Nonnull`. It would be nice if you could annotate...

Can we please set a hard limit on the maximum number of back-and-forth, and close/reject PRs that exceed it? I see the PR does not meet code/performance quality, and I...

@Aaaaaaron , 1) I have no time here. No details, sorry. 2) The comments (e.g. "code/performance", "checkDuplicateSubset") are helpful for other reviewers and committers so they don't accidentally commit the...

One of the solutions is to use dates instead of sequence. The date can be in the filename prefix or it can be in metadata (e.g. file header or commit...

Hi, I see the PR has not been reviewed much yet :) You might be interested that [Gradle 6.2 introduces in-core dependency verification](https://github.com/gradle/gradle/issues/10443#issuecomment-568741472) The documentation can be reviewed here: https://github.com/gradle/gradle/pull/11755...

Just in case, #2555 is not a replacement. #2555 does not verify the dependency supply chain. An alternative option is Gradle Dependency Verification: https://docs.gradle.org/current/userguide/dependency_verification.html