Vladimir Sitnikov

Sample suppressions: https://github.com/apache/calcite/blob/155276591288615c4d02d55fb7d77eceb2e24b2d/core/src/main/java/org/apache/calcite/util/Unsafe.java , https://github.com/pgjdbc/pgjdbc/pull/2015/files#diff-fad1e587e61f470d246ea85f43f1151a0d6adfcecb26c9ada0ae5bdf0fe9534b It looks like one of the best patterns, for now, is an Unsafe class that is excluded from `forbidden-apis` check.

1) Unfortunately, it is not really easy to put JDK-related signatures to custom builds since `forbidden-apis` forbids "unknown signatures". For instance, `Java 10+` has `Collectors#toUnmodifiableSet`, so the signatures easily become...

I know Apache Software Foundation uses a generic copyright notice in file headers (like in log4j: https://github.com/apache/logging-log4j2/blob/ffa6d94a2d48637cbee9832d5fccf3549435921f/log4j-core/src/main/java/org/apache/logging/log4j/core/Filter.java#L2-L6 ) Then there's a small NOTICE file in the repository root: https://github.com/apache/logging-log4j2/blob/ffa6d94a2d48637cbee9832d5fccf3549435921f/NOTICE.txt That...

@Aaaaaaron , it is really sad when the review takes way more time than doing the same thing on my own. This PR has 3 changes: 1) revert 2222. I...

I wonder if "deterministic" should be built in into org.apache.calcite.rel.rules.PushProjector.

@korlov42 , What do you suggest for cases like https://github.com/apache/calcite/blob/f3c09365c2eecbb5198d9acbef638f76053a49a9/mongodb/src/main/java/org/apache/calcite/adapter/mongodb/MongoRules.java#L302-L318 ? It looks like you did not refactor `mongodb` adapter, and I guess it would result in loss of semantics....

@korlov42 , I've lost interest in Calcite, and I have no time for reviewing the PR.

@michaelmior , the review comments are resolved. However it looks like the change fails the build, and I have not analyzed the reason.

@michaelmior , it does not. I think the reason one of Travis job passes is it runs with `SLOW_TESTS=Y`, so only a subset of tests is executed.

Have you seen https://issues.apache.org/jira/browse/CALCITE-2223 ? I think 3455 duplicates 2223, and, unfortunately, there's no trivial solution for it.