Tomás Chor

Results 266 comments of Tomás Chor

I don't see any difference in my simulations after this change. As an example, here's a headland simulation (similar to the paper one but with the original concave bottom) without...

I don't have much insight to give here regarding the problem of maintaining the writers in the future, since I have't changed that part of the code much. Although I...

> @navidcy points out this might already work for lat lon anyways I suspect that's the case as well. @glwagner if that's the case, should we add a test for...

> We should modify the netCDF variable names to `λF`, `λC` or something... I didn't do this in #2979 because I didn't know if NetCDF allows unicode (and because I...

> > The downside of this is that I think it'll be a bit harder to output spacings and other metrics separately in meters and degrees, which I think would...

> I also see that @tomchor has done quite a bit of work with PRs #2652 and #3143. Also happy to help with those. I do see that grid spacings...

> Addresses #4354 > > Things to think about: > > * does this apply to all accumulations? I think so! Can you point me to the accumulations we currently...

> Tests fail because this PR actually changes the meaning of the accumulations. Now we are tasked with defining the first element of the accumulation. For a cumsum this is...

I'm a bit confused about some of the behavior though. Taking one of the tests as an example, you define `T` as a 2x2x2 `CenterField`. in the first y and...

That makes perfect sense, and it was my thought as well. However, the current behavior is that when cumulatively integrating over a periodic dimension, faces and center grids have the...