Greg Thompson

Results 78 comments of Greg Thompson
trafficstars

> Looks like you wrote this component, what do you think? Definitely worth taking another look. These were originally loosely prop-typed JS components, and when I converted them to TS...

"Change all occurrences of `number | string` types to only allow `number`" in **EuiDualRange** and **EuiRangeInput** This is 1) a breaking change and 2) will require simplifying all the related...

Sorry for the delay! I missed the notifications before he review request. I think that `static contextType` is fine for this situation because the most correct approach would be to...

A couple things gone wrong: * The regex to find 3rd party imports does not account for multiline import statements * `@elastic/charts` has peer dependencies that would be missing even...

Yep, I agree that the type is unnecessarily confusing for consumers. My initial read is that the event should be typed as `React.ChangeEvent` and that we handle any `button`-related casting...

Hey @nlatipov This has come up a few times previously (#3399, #4024), and the problem is that the underlying library that supplies the majority of functionality does not support nested...

Thanks for the note, @Xhale1. I hadn't seen that RBD had gone into maintenance mode. We'll need to evaluate the correct direction for EUI in conjunction with an upgrade to...

Mind merging `main`? I want to see CI run times without the flakiness we've been having lately.

It's a valid point, for sure. It would necessitate a new prop, I think, because the current behavior of `minDate` and `minTime` is as intended (and pretty clear).

> Yes, I think adding onClick to the dots would be ideal. I don't recall any discussion about clickable dots, but I don't see any reason why they can't be...