eui icon indicating copy to clipboard operation
eui copied to clipboard

Published 20 hours ago • verified publisher icon elastic

Drag and drop - use new fork

Open Xhale1 opened this issue 3 years ago • 2 comments
trafficstars

Hello!

react-beautiful-dnd is no longer being maintained by Atlassian per their readme. It currently doesn't support React 18 and strict mode.

Another developer and myself created a fork @hello-pangea/dnd which improves a few things:

  • React 18 support
  • React strict mode support
  • React redux 8 support
  • Converted entire codebase and tests to typescript
  • Run test suite with React 16, 17, and 18

@hello-pangea/dnd is a drop-in replacement for react-beautiful-dnd and should require no changes to support aside from renamed imports.

Would Elastic be open to a PR migrating to @hello-pangea/dnd?

Xhale1 avatar Aug 28 '22 07:08 Xhale1

Thanks for the note, @Xhale1. I hadn't seen that RBD had gone into maintenance mode. We'll need to evaluate the correct direction for EUI in conjunction with an upgrade to React 18.

I'll add this to our meta issue tracking required changes: #6182

thompsongl avatar Aug 29 '22 15:08 thompsongl

@thompsongl sounds good. We've received some very positive feedback about migrating to the new fork so I don't anticipate it will be a significant engineering challenge. Naturally there's more than engineering to consider.

Let me know if there's anything myself or other maintainers can help with 👍

Xhale1 avatar Aug 29 '22 15:08 Xhale1

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

github-actions[bot] avatar Feb 25 '23 16:02 github-actions[bot]

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

github-actions[bot] avatar Mar 05 '23 00:03 github-actions[bot]

Re-opening as still valid / related to React 18

cee-chen avatar Mar 06 '23 16:03 cee-chen

This upgrade has happened as part of our React 18 feature branch (which is still not yet available in main / as a release, but will be once the feature branch is deemed ready to go - hopefully in the next month or so here). See https://github.com/elastic/eui/pull/6868

Thanks so much again @Xhale1 for your amazing work with the fork! The upgrade was flawless and cleaned up a bunch of our tests. ❤️ Y'all are amazing!

cee-chen avatar Jul 03 '23 15:07 cee-chen