eui icon indicating copy to clipboard operation
eui copied to clipboard

[EuiMarkdownEditor] CodeSandbox link in Documentation is broken

Open ch-bas opened this issue 3 years ago • 2 comments

Hi, it appears that 'MarkdownEditor' fails to open in code sandbox.

Steps to reproduce:

Go to https://elastic.github.io/eui/#/editors-syntax/markdown-plugins.

Choose Chart Plugin's demo on 'codesandbox'.

Result:

The page contains an error. markdown

ch-bas avatar Aug 12 '22 09:08 ch-bas

Thanks for reporting this issue @ch-bas! 👍🏽

We'll take a look.

elizabetdev avatar Aug 12 '22 13:08 elizabetdev

A couple things gone wrong:

  • The regex to find 3rd party imports does not account for multiline import statements
  • @elastic/charts has peer dependencies that would be missing even if ^ were fixed

thompsongl avatar Aug 12 '22 17:08 thompsongl

@miukimiu or @constancecchen will you take another peek at this one again?

daveyholler avatar Dec 12 '22 18:12 daveyholler

The regex to find 3rd party imports does not account for multiline import statements

This seems to be fixed.

@constancecchen, now we're just missing one dependency:

Screenshot 2022-12-12 at 19 36 55

elizabetdev avatar Dec 12 '22 18:12 elizabetdev