Scott Lahteine

Results 435 comments of Scott Lahteine
trafficstars

Of course, we shouldn't leave the branch in a known broken state, so although it's good to have 27089 as a separate PR that can be merged first (for clarity...

Presumably the call to `goto_screen` after showing the custom boot screen will revert to either Status Screen or Menu custom characters (for `LCD_PRINTER_INFO_IS_BOOTSCREEN`). So I just moved the new code...

I've adjusted the code to just use the single array `customBootChar[][8]` containing all the custom characters. customBootChars ```cpp /** * Up to 8 custom characters of 5 x 8 pixels...

> I used char arrays for ease of design. Although `_Bootscreen.h` is likely to be generated by a tool, it can't hurt to make it more Human-readable. Using strings (where...

Another minor update. Of course character 0 has to be treated specially because it's a string terminator. So I just redefined `CHR0` as `'\x08'` (`BAK`) and that character is replaced...

The current _Bootscreen and code is fine. Those errors are from an earlier iteration. The link to the file works for me, so perhaps refresh the page.

You'll need to rename Icon number 44 in the various icon packs from `ICON_ResumeEEPROM` to `ICON_ResetEEPROM`. I renamed this for clarity since it's being used as a stand-in for a...

For best compatibility with Marlin's DWIN helper scripts, you'll want to organize custom icon packs into "`icons-#`" sub-folders with the same numbering and organization as the `buildroot/share/dwin` folder contents.

What is the procedure to prepare icons 93, 200-206, and 250-254 ? and do these only pertain to TJC? We should add these to `buildroot/share/dwin` for completeness with our "unified"...

I've updated the contents of the `buildroot/share/dwin` folder, so it should now have everything needed to generate the numbered ICO files for sets 3, 4, and 7. If there's anything...