Scott Lahteine

Results 436 comments of Scott Lahteine
trafficstars

The configuration defines `BED_TRAMMING_Z_HOP` as an absolute Z position, and other logic in `_lcd_bed_tramming_probe` and elsewhere in Marlin still depends on that assumption. To change the meaning of this configuration...

It's been a longtime convention for classes to have a method that takes a straight `PSTR` with a "`_P`" suffix in the method name, and then to have the versions...

A quick build test shows that the build size with MarlinUI on AVR isn't significantly impacted by the use of the inline passthrough for FSTR => PSTR. Specifically, removing it...

The net change in this PR is now limited to defining a `ESP_WIFI_MODULE_GPIO15` pin for boards based on BTT OCTOPUS PRO V1. The pin "ESP-CS" is already shown as `PB12`...

One "weird" way to get a notification would be to have the action add a comment to an existing issue, then anyone could subscribe to the issue. Might be worth...

Thank you for doing this excellent analysis and correction. Everything looks great in those graphs. (And nothing pleases us more than pretty graphs.) We'll prioritize getting this reviewed and tested...

> The code that ends up changing step counts is distributed all over the place and some of it is asynchronous. I think it would be difficult to unit test....

> From what I'm now reading FT Motion seems to be a vibration compensation mechanism. It has that, but it's a near complete replacement for Marlin's motion system. FT Motion...

From the discussion it sounds like I ought to merge the (now restored) #26881 first, then we should patch this up afterward. Is there any reason to delay merging #26881?

Another quickie optimization… For values that don't exceed +- 2^30 (i.e., long time periods? counting clock cycles?) it's safe to square before coercing to `float` (instead of coercing to `float`...