David E. Wheeler

Results 436 comments of David E. Wheeler

Got a pull request?

I could also imagine a more direct refactoring of these functions to use `regtype` and `regtype[]` instead of `name` and `name[]`. The only reason they're not `regtype` already is that...

I guess the `-j` flag on `pg_prove` doesn't work for `runtests()` tests?

Yes, you're right, that's what the docs say. I think the simplest way to get parallelism is to create multiple test scripts, each of which runs a discrete subset of...

Does this seem sufficient? ``` patch --- a/doc/pgtap.mmd +++ b/doc/pgtap.mmd @@ -52,7 +52,8 @@ Installation ============ pgTAP must be installed on a host with PostgreSQL server running; it cannot -be...

To be taken on once support for 8.4 is dropped. Might have to tweak things, though, to support both `setof record` and `table`, if it would make existing tests fail.

Is this ready to pull in, @nasbyj?

I'm not sure it would even work then, @nasbyj, because it wouldn't capture all the variants: ``` ll test/expected | grep '_\d\.out$' -rw-r--r-- 1 david staff 5.3K Dec 5 13:00...

If you're thinking you might want to write a slew of these functions, you might want to consider making your own extension that depends on pgTAP and [release it on...

Sure, that make sense. Do please add tests, however.