David E. Wheeler

Results 436 comments of David E. Wheeler

Would this feature, if implemented, render the shortcodes for the current output format? That'd be super great!

Awesome, care to add some tests to `test/sql/functap.sql`?

@cbandy pgTAP has no religion about the type of testing you do, but likes to give you the tools to do your testing well.

Look unhappy on Postgres 10. :-(

Want to make a PR, @rodo?

I'm sorry, I can't tell what you're trying to do here. Is `/tools/testers/pg_prove_tests.sh` responsible for the output there? What's in that script?

I suggest posting to the [mail list](https://groups.google.com/forum/#!forum/pgtap-users) to take the temperature of the community. I've had pretty strong pushback on dropping old versions in the past, but I admit that...

If we drop support for 9.0 and earlier, I'd like to suggest we also commit this change: ``` diff --git a/sql/pgtap--0.98.0--0.99.0.sql b/sql/pgtap--0.98.0--0.99.0.sql index 36ad40a..f7e28cf 100644 --- a/sql/pgtap--0.98.0--0.99.0.sql +++ b/sql/pgtap--0.98.0--0.99.0.sql @@...

Why do you think we'd need to support patch releases in the version returned from `pgtap_version()`?

There should be a `check_ok()` function, too. It should be similar to `fk_ok()`. Query to get started: ``` SELECT pg_catalog.pg_get_constraintdef(r.oid, true) FROM pg_catalog.pg_namespace n JOIN pg_catalog.pg_class c ON n.oid =...