David E. Wheeler
David E. Wheeler
> I agree that a single KMS key should only be used with a single DEK template. For most users, the registration does not really help to achieve that, because...
It would be nice to a non-global registry, which one can implement on one's own. But I still believe the the KMS URI should be stored with the key so...
In your code you can manually set the prefix for envelope keys to use the TINK prefix, at least. That should solve the problem going forward, at least. I think...
> But you must serialize the keyset and not re-create the keyset. Because each time you create a new keyset for the same KMS key, Tink will create a new...
Seems like maybe we could use a function to check for the presence of deploy scripts (on deploy) and revert scripts (on revert) to be called alongside [`check_deploy_dependencies` in `deploy`](/sqitchers/sqitch/blob/5522821/lib/App/Sqitch/Engine.pm#L278)...
Please have a look at #850, which follows your suggestion, @ewie.
Fix released in [v1.5.0](https://github.com/sqitchers/sqitch/releases/tag/v1.5.0).
This seems like it would be a useful function to complement `triggers_are()`, `has_trigger()`, and `trigger_is()`. Name it something like `trigger_events_are()`, which I think fits better with pgTAP's naming conventions (e.g.,...
Yeah you added new tests so you have to update `test/expected/trigger.out`. This should fix it: ``` sh cp results/trigger.out test/expected/trigger.out ``` Sorry for the delayed reply, was completely absorbed in...