tfardet

Results 110 comments of tfardet

OK, thanks for the notice. Out of curiosity, why is the removal of trailing whitespaces important? Could it not simply be fixed by stopping this removal altogether in the library,...

Fixed in [this PR](https://github.com/brightway-lca/brightway2-data/pull/120)

If it's not too much trouble, I think it would make sense to have a small file/db telling when the data was last downloaded and update after a certain period....

woups, [7506899](https://github.com/InseeFrLab/pynsee/pull/196/commits/7506899f8adfb766c764e7338ad24fc89a8c5183) was missing indentation apparently, sorry about that...

OK, will try to look at that by the end of the week! (unless someone else does it first)

Fixed by b6618715e1dc1dabe3e193ca2f1b8ce01d6682fe

I thought we moved to test only against 3.8 and 3.11 but it seems it was reverted at some point later. Was there a specific reason for the reversion or...

OK, good, you can just include it in any of the open PR, then (changing [``pkgTests_pull_requests.yml#L56``](https://github.com/InseeFrLab/pynsee/blob/master/.github/workflows/pkgTests_pull_requests.yml#L56) and [``pkgTests.yml#L54``](https://github.com/InseeFrLab/pynsee/blob/master/.github/workflows/pkgTests.yml#L54))

given that the tests now take a lot less time I'm not sure this is necessary anymore... any opinions?

Here it would be an optional dependency, i.e. it is not required to install ``pynsee``, but if available, it is used. The advantage is that people that have ``geopandas`` installed...