tfardet

Results 110 comments of tfardet

Should we merge this to see whether that fixes the tests and iterate from there if it doesn't? EDIT: nevermind, I think there might actually be an issue with the...

@hadrilec I think your in detail knowledge of INSEE-specific data is required to understand how long this tmpfiles actually need to last, please see my comment on the associated PR...

Great, thanks! > functions using the save_df folder should delete the files so for these, ``TemporaryFile``, ``NamedTemporaryFile``, or ``TemporaryDirectory`` should be used in a context manager > data from _get_full_list_wfs...

great, no ``atexit``, then!

Doesn't platformdirs basically guarantee that we'll have the rights to create the folder? I wonder whether everything could not be replaced by ``platformdirs.user_cache_dir("pynsee", ensure_exists=True)`` BTW: is there a reason why...

@hadrilec I had to change the SIRENE URL in init_conn; since the default API is now 3 and the old V3 link did not work anymore. I also removed the...

@tgrandje can we close this?

Thanks for that, should we add ``ignore_errors=True`` to ``rmtree``?

Reading the PR in more details, I'm actually not sure I understand what should be going on here. For instance, you're [clearing the tmpdir generated by a function relying on...

> wherever there is a call to `_create_insee_folder`, it might be worth checking if functions can be rewritten to use the `@save_df` decorator instead (it could simplify maintainance on the...