pynsee icon indicating copy to clipboard operation
pynsee copied to clipboard

Test against relevant python versions

Open tfardet opened this issue 2 years ago • 7 comments

I'd propose to stop testing against python 3.7, as it already reached end of life and start using 3.11 instead.

I also wonder whether it is necessary to test against all intermediate versions and whether oldest and newest alone would not be sufficient (especially given how long the tests take to run). No strong opinion, though, just wondering whether it's worth it.

tfardet avatar Aug 22 '23 08:08 tfardet

Indeed, great idea, let's discontinue the testing on 3.7, and test only on 3.8 and 3.11 then. The tests module, should be adapted though because some tests are run only on 3.7

hadrilec avatar Aug 22 '23 08:08 hadrilec

OK, will try to look at that by the end of the week! (unless someone else does it first)

tfardet avatar Aug 22 '23 08:08 tfardet

I'll handle this at the same time as the caching of tests.

tgrandje avatar Aug 28 '23 12:08 tgrandje

I made this commit 860e27a3a058edf1c760171d3ae8f66275b78cdb in the PR #162, tests will be performed only on 3.8 and 3.11

hadrilec avatar Nov 19 '23 11:11 hadrilec

after the merger of this PR #180, tests are made only on python 3.8 and 3.11

hadrilec avatar Dec 27 '23 18:12 hadrilec

Fixed by b6618715e1dc1dabe3e193ca2f1b8ce01d6682fe

tfardet avatar Jan 08 '24 08:01 tfardet

I thought we moved to test only against 3.8 and 3.11 but it seems it was reverted at some point later. Was there a specific reason for the reversion or should we move back to 3.8 and 3.11 only? Should we even move to 3.8 and 3.12 now that it's out?

More generally, should we define a policy for the python version we test? (I would propose to test against earliest version with security support and latest version only)

tfardet avatar Apr 05 '24 11:04 tfardet