terraform-example-foundation

terraform-example-foundation copied to clipboard

### TL;DR - In [0-bootstrap/terraform.examples.tfvars](https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/0-bootstrap/terraform.example.tfvars#L40), group names don't align with documentation on the [Cloud Architecture Center](https://cloud.google.com/architecture/security-foundations/authentication-authorization#groups_for_access_control) - There is an audit_data_users group in the Terraform that doesn't exist in the...

arueth

fix: typo in local name

2

The local name is only used once in the entire repo.

th3r3ald0n

Add destroy option in tf-wrapper.sh

8

The tf-wrapper.sh have 3 options of terraform execution: init, plan and apply. I've missed the destroy option when my terraform state got inconsistent. The easier way was destroy and re-apply....

amandakarina

Out-of-order dependencies issues with `A-VALID-PROJECT-ID` in bootstrap

2

### TL;DR https://github.com/terraform-google-modules/terraform-example-foundation/blob/44d51df886e165098ebbd13a02ac1b26ac9c2b6e/0-bootstrap/README.md Written employment instructions in the bootstrap stage recommend use of `A-VALID-PROJECT-ID` as a billing and quota project for the terraform validator. This is poor usability and out-of-order...

eeaton

chore: create access context manager policy ID in test if needed

3

This PR will toggle the creation of the access context manager policy ID in the test in step 1-org if it does not exist in the organization. This will fix...

daniel-cit

fix!: use bootstrap.outputs.common_config as default region

78

This PR adds some additional outputs `bootstrap.outputs.common_config` and uses these values by default. This fixes the issue of resources being deployed in `us-central1` and `us-west1` which was caused by module...

nbugden

fix: bump terraform base version from 1.3.0 to 1.3.10

1

Because of the issue described in this link: https://github.com/hashicorp/terraform/issues/34014 Some users may experience this error: ```text unsupported checkable object kind "var" ``` This can easily be fixed by upgrading the...

caetano-colin

chore(deps): Update cft/developer-tools Docker tag to v1.21

8

[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | cft/developer-tools | minor | `1.20` -> `1.21` | --- ### Configuration 📅 **Schedule**:...

renovate[bot]

fix(VPCSC): enable dryrun mode

4

Address issue #1209 . CI tests have high flaky failure rate due in part to propagation delays with VPCSC perimeter. Changing this to dry mode better adheres to best practices...

eeaton

### TL;DR assigned to https://github.com/fmichaelobrien PR developed in fork https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/issues/407 specifically the prerequisites sections with roles and service enablements duplicated across "For the user who will run the procedures in...

obriensystems