terraform-example-foundation

terraform-example-foundation copied to clipboard

1-org requires securitycenter.notificationconfig.get permissions - add Security Center Admin role after enabling SCC - new org issue (where SCC was not enabled yet)

2

### TL;DR add Security Center Notification Configurations Editor for step 3 of https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/1-org/README.md#deploying-with-cloud-build ``` export ORGANIZATION_ID=$(terraform -chdir="../terraform-example-foundation/0-bootstrap/" output -json common_config | jq '.org_id' --raw-output) gcloud scc notifications describe "scc-notify" --organization=${ORGANIZATION_ID}...

obriensystems

Enterprise cloud setup wizard migration to the TEF

1

### TL;DR Start procedures on removing the non-terraform parts of the ECS or a procedure to interleave the 2 This particular case ended at a partial group creation where 2...

obriensystems

Readme adjustments: 0-bootstrap

1

### TL;DR Ongoing... add a link to the tfvars for the following https://github.com/terraform-google-modules/terraform-example-foundation/tree/master/0-bootstrap#prerequisites ``` Add the user who will use Terraform to the group_org_admins group. They must be in this...

obriensystems

In validation script - change main branch check to master - there is no main

2

### TL;DR in https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/0-bootstrap/README.md#deploying-with-cloud-build adjust https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/scripts/validate-requirements.sh#L127 ``` if ! git config init.defaultBranch | grep "main" >/dev/null ; then echo " git default branch must be configured as main." echo "...

obriensystems

branch instructions are not accurate - main should be master and/or handle development branches

2

### TL;DR Branch instructions are not accurate https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/docs/TROUBLESHOOTING.md#default-branch-setting - there is no main branch so we should use master - what if we are doing development on a ghNNN-name branch?...

obriensystems

0-bootstrap needs cloudbilling api enabled on seed project

1

### TL;DR ``` michael@cloudshell:~/tef-olapp/github/terraform-example-foundation/0-bootstrap (tef-olapp)$ gcloud services enable cloudbilling.googleapis.com Operation "operations/acat.p2-153288813308-9c2dddaa-7b1d-4ac0-bd9c-3fe344d1e782" finished successfully. ``` ### Expected behavior _No response_ ### Observed behavior _No response_ ### Terraform Configuration ```hcl cloud shell...

obriensystems

0-bootstrap needs iam api enabled on seed project - adjust reame

1

### TL;DR ``` michael@cloudshell:~/tef-olapp/github/terraform-example-foundation/0-bootstrap (tef-olapp)$ gcloud services enable iam.googleapis.com Operation "operations/acat.p2-153288813308-7f675593-6ea2-4bcc-ac0c-09b4d227de62" finished successfully. ``` ### Expected behavior _No response_ ### Observed behavior ``` during apply oogle_service_account.terraform-env-sa["proj"]: Creating... google_service_account.terraform-env-sa["org"]: Creating... google_service_account.terraform-env-sa["env"]:...

obriensystems

0-bootstrap needs iam api enabled on seed project - adjust reame

1

### TL;DR ``` terraform apply google_billing_account_iam_member.billing_admin_user["env"]: Creation complete after 20s [id=012EDD-5AD5ED-ECFF0B/roles/billing.admin/serviceAccount:[email protected]] ╷ │ Error: Error creating KeyRing: googleapi: Error 403: Cloud Key Management Service (KMS) API has not been used...

obriensystems

0-bootstrap needs servicenetworking api enabled on seed project

1

### TL;DR ``` terraform apply google_artifact_registry_repository_iam_member.terraform_sa_artifact_registry_reader["org"]: Creation complete after 21s [id=projects/prj-b-cicd-wm4z/locations/us-central1/repositories/tf-runners/roles/artifactregistry.reader/serviceAccount:[email protected]] ╷ │ Error: Error waiting for Create Service Networking Connection: error while retrieving operation: googleapi: Error 403: Service Networking...

obriensystems

0-bootstrap needs a setup.sh script - I will add

1

### TL;DR see all issues with 0-bootstrap - https://github.com/terraform-google-modules/terraform-example-foundation/issues/1135 - https://github.com/terraform-google-modules/terraform-example-foundation/issues/1136 - https://github.com/terraform-google-modules/terraform-example-foundation/issues/1137 - https://github.com/terraform-google-modules/terraform-example-foundation/issues/1138 - https://github.com/terraform-google-modules/terraform-example-foundation/issues/1139 - https://github.com/terraform-google-modules/terraform-example-foundation/issues/1140 - https://github.com/terraform-google-modules/terraform-example-foundation/issues/1141 - https://github.com/terraform-google-modules/terraform-example-foundation/issues/1142 - https://github.com/terraform-google-modules/terraform-example-foundation/issues/1143 ### Expected behavior _No response_...

obriensystems