terraform-example-foundation

terraform-example-foundation copied to clipboard

### TL;DR However nowhere in the environment a hierarchical FW rule with this name is visible This is the error Error: Error creating OrganizationSecurityPolicy: googleapi: Error 400: Invalid value for...

mromascanu123

Make optional the deployment of "example' resources adding up to the cost and complexity

1

### TL;DR For each VPC in the spokes can see a servicenetworking peering associated with an instance of private-service-access in 3-networks-hub-and-spoke/modules/restricted_shared_vpc/main.tf ... resource "google_service_networking_connection" "private_vpc_connection" { count = var.private_service_cidr !=...

mromascanu123

chore(functions): update cloud functions to specify build SA

4

to address https://github.com/terraform-google-modules/terraform-example-foundation/issues/1269. I haven't been able to test it because our CI test org was not impacted by the default changes to cloud build SA, and has not encountered...

eeaton

chore(deps): Update module github.com/gruntwork-io/terratest to v0.46.16

2

[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/gruntwork-io/terratest](https://togithub.com/gruntwork-io/terratest) | `v0.46.15` -> `v0.46.16` | [](https://docs.renovatebot.com/merge-confidence/)...

renovate[bot]

fix(deps): update dependency @google-cloud/security-center to v8.9.0

3

[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@google-cloud/security-center](https://togithub.com/googleapis/google-cloud-node/tree/main/packages/google-cloud-securitycenter) ([source](https://togithub.com/googleapis/google-cloud-node/tree/HEAD/packages/google-cloud-securitycenter)) | [`8.8.0` -> `8.9.0`](https://renovatebot.com/diffs/npm/@google-cloud%2fsecurity-center/8.8.0/8.9.0) |...

renovate[bot]

chore(deps): update terraform terraform-google-modules/vpc-service-controls/google to v6

1

[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [terraform-google-modules/vpc-service-controls/google](https://registry.terraform.io/modules/terraform-google-modules/vpc-service-controls/google) ([source](https://togithub.com/terraform-google-modules/terraform-google-vpc-service-controls)) | module | major | `~> 5.0` -> `~>...

renovate[bot]

chore(deps): update terraform googlecloudplatform/cloud-functions/google to ~> 0.6

2

[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [GoogleCloudPlatform/cloud-functions/google](https://registry.terraform.io/modules/GoogleCloudPlatform/cloud-functions/google) ([source](https://togithub.com/GoogleCloudPlatform/terraform-google-cloud-functions)) | module | minor | `~> 0.5` -> `~>...

renovate[bot]

### TL;DR There is an examples on how to implement all the foundation steps for GitLab in `0-bootstrap/envs/shared/README-GitLab.md` But nothing for infrastructure `4-projects` and `5-app-infra` steps. It would be very...

KonStg

Rename stage 5-app-infra for internal consistency on pipeline layers (foundation vs infra vs application)

1

### TL;DR Terminology and concepts are not used consistently for different pipeline layers, and it breaks down at stage 5-app-infra. This should be renamed to help clarify how the enterprise...

eeaton

remove `data_access_logs_enabled`

1

### TL;DR There is no practical recommendation to use `data_access_logs_enabled` in any realistic scenario. I suggest we remove it. An earlier version implemented this variable by default and rolled it...

eeaton