Results 192 comments of Liav A.

Now relies on #18654. Setting this to be a draft until that PR is merged.

This is blocked until #18574 is merged.

This is ready for review (and possibly merging as well) :)

I will just put my comment from the discord server here as well: https://discord.com/channels/830522505605283862/830525093905170492/1116063101176008805 >[8:56 PM]supercomputer7: disk-cache should be removed [8:56 PM]supercomputer7: it is utterly incapable in its design for...

The next-next PR to be in the queue, as I said before, is #12885.

CI was red, so let's see if it's now green. Anyway, I wrote (about 2 weeks ago already) the commit messages, so reviews on this are appreciated as always!

Putting a reminder from https://github.com/SerenityOS/serenity/pull/18654#discussion_r1193205709 to remove stale includes here.

Next PR about this topic will probably change things so there will be a different process to handle Power events (maybe a WorkQueue?), and we still need to tear down...

> Code changes look fine (though bordering on feng shui slightly_smiling_face) Regarding the commit message, it's a whole paragraph that is made up of a single sentence, let's try to...

> Code changes look fine (though bordering on feng shui slightly_smiling_face) Regarding the commit message, it's a whole paragraph that is made up of a single sentence, let's try to...