Sunjay Bhatia

Results 279 comments of Sunjay Bhatia

> As a bit of inspiration, there's also this [incredibly helpful spreadsheet for ingress controllers](https://docs.google.com/spreadsheets/d/191WWNpjJ2za6-nbG4ZoUMXMpUK8KlCIosvQB0f-oq3k/edit#gid=907731238) that had a lot of the same goals we're trying to accomplish here. +1 to...

Sounds reasonable to offer the configurability of this field to allow users to run their Envoy's in line with Envoy's "L2" guidelines: https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/network/http_connection_manager/v3/http_connection_manager.proto#envoy-v3-api-field-extensions-filters-network-http-connection-manager-v3-httpconnectionmanager-stream-error-on-invalid-http-message This would have to be a new...

that sounds great @deveshk0, I'll assign this issue to you, feel free to reach out for any help you need 👍🏽

panic in controller-tools should be fixed by bumping to latest 0.16.4: https://github.com/kubernetes-sigs/controller-tools/pull/1061

ah actually turns out it wasnt fixed entirely: https://github.com/kubernetes-sigs/controller-tools/issues/1076

> Calling this one ready for review, are others comfortable moving forward with this cleanup? yep I'll take a look!

> There are several other types that also use `+required`, but only `ExtensionServiceReference.Name` is causing the test suite to fail. > > I believe backwards compatible fix would be to...

I would argue `version` could maybe be a commit SHA or something similar not necessarily only a semver

https://github.com/projectcontour/contour/pull/6546 was merged, closing this as completed

[goroutine-dump.log](https://github.com/user-attachments/files/20779037/goroutine-dump.log) here's an example of a goroutine dump of the shim (formatting not great)