contour icon indicating copy to clipboard operation
contour copied to clipboard

remove contour xDS server implementation

Open skriss opened this issue 1 year ago • 1 comments

skriss avatar Jul 19 '24 20:07 skriss

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.72%. Comparing base (8c988b5) to head (644846f). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/contour/serve.go 0.00% 5 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6568      +/-   ##
==========================================
- Coverage   81.07%   80.72%   -0.36%     
==========================================
  Files         134      131       -3     
  Lines       20087    19799     -288     
==========================================
- Hits        16286    15983     -303     
- Misses       3507     3526      +19     
+ Partials      294      290       -4     
Files with missing lines Coverage Δ
cmd/contour/servecontext.go 84.34% <ø> (-0.18%) :arrow_down:
internal/contourconfig/contourconfiguration.go 98.17% <ø> (-0.02%) :arrow_down:
internal/xds/v3/callbacks.go 100.00% <100.00%> (ø)
internal/xdscache/v3/cluster.go 100.00% <ø> (ø)
internal/xdscache/v3/endpointslicetranslator.go 74.51% <ø> (-7.27%) :arrow_down:
internal/xdscache/v3/endpointstranslator.go 87.45% <ø> (-1.68%) :arrow_down:
internal/xdscache/v3/listener.go 91.56% <ø> (-0.45%) :arrow_down:
internal/xdscache/v3/route.go 96.90% <ø> (-0.56%) :arrow_down:
internal/xdscache/v3/runtime.go 97.43% <ø> (-2.57%) :arrow_down:
internal/xdscache/v3/secret.go 66.66% <ø> (-10.70%) :arrow_down:
... and 2 more

... and 2 files with indirect coverage changes

codecov[bot] avatar Jul 19 '24 20:07 codecov[bot]

Calling this one ready for review, are others comfortable moving forward with this cleanup?

skriss avatar Jan 08 '25 17:01 skriss

Calling this one ready for review, are others comfortable moving forward with this cleanup?

yep I'll take a look!

sunjayBhatia avatar Jan 13 '25 20:01 sunjayBhatia

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions[bot] avatar Jan 29 '25 00:01 github-actions[bot]

Merge conflicts resolved

skriss avatar Feb 06 '25 13:02 skriss