gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

Validate conformance profiles suite flag values

Open mlavacca opened this issue 2 years ago • 6 comments

What would you like to be added:

https://github.com/kubernetes-sigs/gateway-api/pull/2066 added a new CLI to run conformance profiles. This CLI accepts the following flags related to the implementation running the test suite:

  • organization
  • project
  • url
  • version
  • contact

We need to validate that:

  • url is a valid url
  • version is a valid semver
  • contact contains only valid contacts (@fake_user or [email protected])

mlavacca avatar Jul 11 '23 08:07 mlavacca

/area conformance

mlavacca avatar Jul 11 '23 08:07 mlavacca

Seems like some good smaller improvements.

/triage accepted

I hesitate to consider it a good-first-issue because it requires someone work on the experimental CLI, and have an implementation they're attaching to conformance, e.t.c. but I do think it's relatively low-hanging fruit for anyone already in that boat.

Not required for GA, but should be worked on not too long after that.

/priority important-longterm

shaneutt avatar Jul 21 '23 18:07 shaneutt

I would argue version could maybe be a commit SHA or something similar not necessarily only a semver

sunjayBhatia avatar Jul 21 '23 19:07 sunjayBhatia

I would argue version could maybe be a commit SHA or something similar not necessarily only a semver

That within itself may be a good reason to do a small GEP update only doing that so we can work through it and discuss it.

shaneutt avatar Jul 24 '23 13:07 shaneutt

/cc

tssurya avatar Sep 23 '23 09:09 tssurya

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot avatar Sep 22 '24 10:09 k8s-triage-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 21 '24 10:12 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jan 20 '25 11:01 k8s-triage-robot

This is still relevant.

/reopen /assign

mlavacca avatar Jan 20 '25 11:01 mlavacca

/remove-lifecycle rotten

mlavacca avatar Jan 20 '25 11:01 mlavacca