Jack Grigg

Results 886 comments of Jack Grigg
trafficstars

[Force-pushed](https://github.com/flipperzero-rs/flipperzero/compare/22ee3a3d9c3fd051493dfc8e9c9943d1c5c1d6da..033173a0f4c14ea343d305258f9f372b429f1084) to address comments.

[Rebased on current `main`](https://github.com/flipperzero-rs/flipperzero/compare/94a103596bcbf2ec503fa1f60102651cddd6c913..8c7c40e35145a7c8ca4b7c33a227460476dc9650).

Pushed a commit to switch to latest nightly for stabilised `cfg_target_abi` (and fix resulting Clippy lints).

@JarvisCraft I put this together as an initial context-less (for simplicity) approach (as part of trying to get the NFC bindings working), then saw that the view dispatcher (my actual...

`--bin storage -- list` seems to be slower than the text CLI version. Not sure there's much we can do about that.

[Rebased on `main`](https://github.com/flipperzero-rs/flipperzero/compare/b9905531d2e7a624d2e67d7d0a3526c78d248e03..87cbc4d2dccf7e0511b73520925e84b2e1c1157f).

[Force-pushed](https://github.com/flipperzero-rs/flipperzero/compare/87cbc4d2dccf7e0511b73520925e84b2e1c1157f..22747a941fa83dda10d6af836921460f6698a208) to clean up the protobuf generation and move the output files into a submodule, making room for other submodules under `proto` for organising the async impl.

We're going to have a very hard time of this, because [Miri doesn't yet support arbitrary FFI calls](https://github.com/rust-lang/miri/issues/11). I've locally made changes that enable `MIRI_NO_STD=1 cargo miri test --target thumbv7em-none-eabihf`...

Aha, I missed the `-Zmiri-extern-so-file=` experimental flag. So Miri does support at least simple FFI calls that only have integer (or void) args and return. That won't help for the...