Jack Grigg

> After having read BIP 370 thoroughly, I just don't understand the design of this API. [BIP 370](https://github.com/bitcoin/bips/blob/master/bip-0370.mediawiki#constructor) says, for the Constructor: > > > Before any input or output...

[Rebased on `main`](https://github.com/zcash/librustzcash/compare/361653b55ea6366cbe1bbfa002f68cd37736bede..426e29eae4a2ed1b4cad144307fc42707bcffc04) to fix merge conflict in changelog.

[Force-pushed](https://github.com/zcash/librustzcash/compare/426e29eae4a2ed1b4cad144307fc42707bcffc04..ced6316d3017ebbd0bc527dd08487f1764a234f7) to remove unnecessary `tor_dir` permissions changes, and address CI lints.

[Force-pushed](https://github.com/zcash/librustzcash/compare/ced6316d3017ebbd0bc527dd08487f1764a234f7..ee6902b5346d080ffa3a72fe4c7979077e0ae2e5) to not pass `ExchangePair` through to the individual queriers. Only two exchanges offer actual `USD/ZEC` pairs (the rest are `USDT/ZEC`), and even if we could get data for e.g....

[Rebased on `main`](https://github.com/zcash/librustzcash/compare/ee6902b5346d080ffa3a72fe4c7979077e0ae2e5..8fb7d772a482e1bf4661f461bb51573424e76263) after TEX address support landed.

[Force-pushed](https://github.com/zcash/librustzcash/compare/8fb7d772a482e1bf4661f461bb51573424e76263..675490e9a02f672cacc235829842e030a2965400) to rework the exchange rate API to allow callers to customise the exchanges (or define their own data sources).

[Force-pushed](https://github.com/zcash/librustzcash/compare/675490e9a02f672cacc235829842e030a2965400..ac5bac9969ff3890240a281ac784bb705af7019f?w=1) to address review comments.

We should also take into account the fact that when checking balances, we often do want to use `min_confirmations = 0` for shielded pools (so that balance doesn't temporarily drop),...

> (and for shielded pools, potentially different between own-wallet notes and externally-received notes). To expand on / clarify what I meant here: we realised a while back that we don't...

The comment that the above discussion was referring to was [invalidated](https://github.com/zcash/zips/pull/607#issuecomment-1836539293). So we're back in the position where we want to separate "confirmation depth" from "anchor depth" matching what we...