Jack Grigg

Results 890 comments of Jack Grigg
trafficstars

I'm currently attempting to work out the implementation for this. There are several things that a wallet needs to select in order to produce a transaction proposal: - The anchor...

Correct, this is the issue that your PR closes, and AFAICT your PR covers everything we've previously discussed here.

Hmm, after deciding to do this, I took another look at @FiloSottile's `age` and realised that although its `Identity` only exposes multi-stanza unwrapping, every single impl uses an internal [`multiUnwrap`...

IDK why CI is failing here, when equivalent setups work with this version in other repos I manage. Gonna merge it and see what happens.

@daira raised a concern that there might be social pressure to maintain compatibility with a particular version of a nightly feature. That is not the intention of nightly; people relying...

In Office Hours today we discussed this issue. The general policy I want to push for (and that we have general agreement over) is that maintainers of the Halo 2...

The motivating example here was that the exception raised on line 113 (which was in this case "not enough rows") was not raised in a user's code, causing `Circuit::synthesize` to...

This is probably left over from when `pow_vartime` was on `FieldExt` and took a fixed-length array (IIRC). Generally +1 on the PR, but I'm on PTO and am not reviewing...