Jack Grigg

Results 899 comments of Jack Grigg

@ebfull and I paired on figuring out the DAG. There are two main components to the user-facing API: - Circuits. - Forced to use a certain field. - Given opportunity...

The high-level API being designed for this issue won't allow for that use case, because getting that cross-circuit interaction right is tricky and requires care, and is and not something...

CompactNotes do not contain `outCiphertext` (we trimmed out absolutely everything we could to make trial-decryption bandwidth as minimal as possible), so this can't be done without making those notes less...

This would be _perfect_ to go in a crate of Zcash primitives, which is what `zcash_primitives` was sort-of intended as. It has in practice grown significantly, so while I'd like...

This will conflict with @nuttycom's work to deduplicate the transaction building logic in `z_mergetoaddress` and `z_shieldcoinbase`; I'm happy to wait on this PR until that work is merged.

Hmm, this actually ends up taking longer, because for some reason the sequence of compiles it triggers takes longer overall, plus we have several minutes compiling and installing `cargo-nextest` itself....

(Below I ignore the 2m 50s for building the param-fetching binary, which is unchanged) [Without this PR](https://github.com/zcash/librustzcash/runs/5325128468?check_suite_focus=true): - Run tests and doc tests (7m 34s) - 6m 06s building, 1m...

> I think the following is interesting. [zkcrypto/bls12_381#84](https://github.com/zkcrypto/bls12_381/pull/84) We can reduce Montgomery reduction for each field array arithmetic. This affects so much. > > * [eval_poly](https://github.com/zcash/halo2/blob/main/halo2_proofs/src/arithmetic.rs#L269) > > * [compute_inner_product](https://github.com/zcash/halo2/blob/main/halo2_proofs/src/arithmetic.rs#L279)...

> In terms of `assembly optimizations for pasta field arithmetic`, it's necessary to update rust version. The `asm` feature is stable latter than 1.59.0. If it's okay to update, I...

> I think this logic can be applied for `[F] ⚪︎ [F]` or `F ⚪︎ [F]` operation for any arithmetic `⚪︎` as long as they keep equivalence relation. It reduces...