Jack Grigg

Results 903 comments of Jack Grigg

Sorry, I didn't mean to imply this issue should be closed. We still will need to address this for at a minimum CI purposes, and whatever solution is arrived at...

`VerifyingKey::{read, write}` were removed, as we still need to define a stable serialization format for viewing keys (#449). I'm repurposing this issue to be the same task for proving keys.

Given how @nuttycom implemented the cache DB traits, this should just be a case of writing a new trait implementation, and then the downstream consumers of `zcash_client_sqlite` (the SDKs) can...

Ooh nice, I didn't know about this new GitHub feature! My hope is it interacts nicely with tags, since it would be ideal for people to be able to cite...

I don't think that `z_removeaddress` is the right API for `zcashd`, for several reasons: - Removing the spending key associated with an address does not necessarily remove the ability to...

I would prefer that we: - Expose the kinds of required column usages in configuration (like we do in e.g. the [Sinsemilla chip](https://github.com/zcash/halo2/blob/c12620c598a15f6686767b4cb6ba145396d6d4df/halo2_gadgets/src/sinsemilla/chip.rs#L147-L154)). - Equality-constrain the columns we need (i.e....

I've split out the concrete tasks into separate issues. Leaving this issue open until we decide where to have discussions about the threat model and reorg handling.

I think I'm starting to understand what is going on here. `semOutbound` is used to control how many outbound network connections are allowed to be active: https://github.com/zcash/zcash/blob/aad3da4d3aa96a25dab5f762fbd5a0c0d2700346/src/net.cpp#L1936-L1940 Every avenue that...

I think this might have been caused by #5057 (which we merged after 5.0.0), specifically the backport of https://github.com/zcash/zcash/commit/4ad38a45e5fc24c4fbd89f6417f3a4e39daa3383 which switched `sync.{cpp, h}` from Boost threading primitives to std threading...

#5982 fixes the deadlock by partially reverting the commit to move `CSemaphore` back to Boost threading primitives. We will need to delay that part until after we've figured out why...