Jack Grigg

Results 899 comments of Jack Grigg

#6107 is likely a duplicate of this, which means others outside ECC are also encountering this state. The crash is occurring during the handling of Orchard rewinds: https://github.com/zcash/zcash/blob/92b21576e09e2d6a6f7665dfca4ef7fd447e78ec/src/wallet/wallet.cpp#L4694-L4718 Specifically, `orchardWallet.Rewind()`...

I think so! I improved the main error type in #338, but there is still more to do. I've updated the top post accordingly.

I think a good starting point would be to refactor `VerifyFailure::Permutation` to use `location: FailureLocation` instead of `row: usize`. Identifying the actual region responsible was much harder than just listing...

In a meeting today, @ebfull noted a specific soundness requirement for this: the prover must only be able to assign to columns involved in a challenge prior to that challenge...

In the office hours today, @han0110 commented that adding a type parameter to `Column` required widescale changes to the codebase. To minimise this, I suggested an alternate approach, where we...

There's another issue we noticed during the Arborist call today: `CompactSize` as inherited from Bitcoin Core has a limit of 2^26, but it is used in FlyClient nodes to (among...

This is likely blocked on some of the networking code backports.

This issue is likely addressed (either directly or as a side-effect) in the upstream networking refactor PRs.

See also https://github.com/zcash/halo2/issues/509#issuecomment-1146025689 where I describe an alternate API that would make this less of a problem.