Steven Weerdenburg
Steven Weerdenburg
This was closed via #4100
This came up in a recent PR again. @CharliePoole gave the helpful context in the originating issue that the `CollectionAssert` class was at one point considered for removal. Given the...
True. I suspect outright removing them could be disruptive. Marking them as obsolete but leaving them in could be less disruptive, but potentially still unpleasant for anyone with a build...
Good idea about EditorBrowsable. @manfred-brands Just to be sure I understand what you are thinking, are you suggesting we mark `CollectionAsserts`, `FileAsserts`, `TypeAsserts`, and `StringAsserts` as obsolete in `4.x` or...
I'm ok with actually marking them as obsolete in `3.x` too, I think this is something we've already done with a few other APIs. I just would advocate for an...
I had forgotten about the classic asserts package, that sounds ideal. I've been trying to think about if there's any way to use typeforwards for this in the 3.x branch...
Thanks for taking a look at this @OsirisTerje and experimenting with an alpha release of the adapter. I'll also try to take a second look at this when I am...
Thanks @OsirisTerje ! I'm not at a computer at the moment, but the main change I can recall between the branches aside from the version bump is that some older...
It sounds like there's been generally positive feedback about this idea so I'm going to upgrade it to an enhancement.
Revisiting this, I am inclined to agree and close as not a bug. [The documentation](https://docs.nunit.org/articles/nunit/writing-tests/constraints/EqualConstraint.html#comparing-arrays-collections-and-ienumerables) suggest using the `AsCollection` equality modifier in this case, where both `IEnumerable` and `IEquatable` are...