Steffen Larsen
Steffen Larsen
Precommit failure is a known issue (https://github.com/intel/llvm/issues/10380)
The Gen12 Windows failures are reported in https://github.com/intel/llvm/issues/12797 and https://github.com/intel/llvm/issues/12798 so they are completely unrelated to these changes. The Linux one I've heard was a problem in passing. I suspect...
Review still required from @intel/unified-runtime-reviewers & @intel/dpcpp-tools-reviewers. Friendly ping.
This is to adjust for upcoming releases, including current https://github.com/intel/llvm. Note that `sycl::device_ptr` and `sycl::host_ptr` were deprecated in 2024.2.
@GarveyJoe - What is the current status of this? Have all the comments been addressed in the current implementation?
@konradkusiak97 - It looks like this may have caused https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/Basic/out_of_order_queue_status.cpp to fail on Gen12. Could you please have a look?
Windows Gen12: ``` Failed Tests (8): SYCL :: Assert/assert_in_kernels_win.cpp SYCL :: Assert/assert_in_multiple_tus_one_ndebug_win.cpp SYCL :: Assert/assert_in_multiple_tus_win.cpp SYCL :: Assert/assert_in_one_kernel_win.cpp SYCL :: Assert/assert_in_simultaneous_kernels_win.cpp SYCL :: Assert/assert_in_simultaneously_multiple_tus.cpp SYCL :: Assert/assert_in_simultaneously_multiple_tus_one_ndebug.cpp SYCL :: Plugin/sycl-ls-unified-runtime.cpp...
Windows Gen12: ``` Failed Tests (8): SYCL :: Assert/assert_in_kernels_win.cpp SYCL :: Assert/assert_in_multiple_tus_one_ndebug_win.cpp SYCL :: Assert/assert_in_multiple_tus_win.cpp SYCL :: Assert/assert_in_one_kernel_win.cpp SYCL :: Assert/assert_in_simultaneous_kernels_win.cpp SYCL :: Assert/assert_in_simultaneously_multiple_tus.cpp SYCL :: Assert/assert_in_simultaneously_multiple_tus_one_ndebug.cpp SYCL :: Plugin/sycl-ls-unified-runtime.cpp...
> @intel/llvm-gatekeepers PR has been fully approved, please merge whenever possible. There seem to be compilation issues.
Typically we would want the extension approved and merged before we consider merging the implementation of it. As such https://github.com/intel/llvm/pull/8852 should be first, I would argue.