Steffen Larsen

Failure on Windows is after testing and is infrastructural.

I would like @jinge90 to review this and maybe share some thoughts on the discussions above, especially pertaining to doing this for SPIR-V.

Approval still needed from @intel/dpcpp-sanitizers-review (e.g. @yingcong-wu )

@AllanZyne - The following tests are failing in post-commit after this: SYCL :: AddressSanitizer/invalid-argument/out-of-bounds.cpp SYCL :: AddressSanitizer/invalid-argument/released-pointer.cpp SYCL :: AddressSanitizer/nullpointer/global_nullptr.cpp Please address these ASAP or we will will have to...

@yingcong-wu - Thank you for making me aware! Looking at the changes, I don't think we need a full revert. If I'm reading it correctly, it seems like we didn't...

> > Thank you for making me aware! Looking at the changes, I don't think we need a full revert. If I'm reading it correctly, it seems like we didn't...

I agree, this should not be able to affect the device and as such it seems to be an infrastructure issue.

Hi @al3x-jp! I took the liberty of rebasing this patch, applying clang-format, and fixing the test issues. Hope is that the CI should be green shortly.

Seems to be some unexpected failures on Gen12. I will look into this ASAP.

Seems that OpenCL doesn't allow vectors in SPIR-V shuffle operations. By scalarizing the vectors we can work around this, expecting the device-compiler to vectorize the operation if it sees fit....