Benedikt Franke

Results 451 comments of Benedikt Franke

Requires https://github.com/symplify/rule-doc-generator to support Laravel 11.

Thanks @eshimischi, awaiting a tag following 12.1.2, see https://github.com/symplify/rule-doc-generator/tags.

@simPod 7 tests are failing for me locally. Do you have any idea why they work in CI but not locally? I have PHP 8.3.3 installed. ``` There were 7...

Thanks for digging in. Do you think that specifying the INI settings in `composer test` makes sense the way i did it?

I would probably be a good idea to extend the tutorial with those, perhaps even before the queries to allow seeding test data.

Doing this right is a tricky, since `LogGraphQLQueries` just looks at the plain JSON parameters. Because GraphQL values can be passed as literals inside the query string, we need access...

Hey @erjanmx. We are using your package in a project and are trying to update to Laravel 11. I have installed from the Laravel Shift fork as described in https://github.com/erjanmx/laravel-migrate-check/pull/23#issuecomment-1964584271...

There might be insufficient cleanup related to caching. Consider https://github.com/nuwave/lighthouse/blob/c28822acdb675ce3be99339c8bebf243bf0666e3/src/GraphQL.php#L350-L355 - perhaps something similar is also required for caching? The schema cache is dealt with in https://github.com/nuwave/lighthouse/blob/master/src/Schema/AST/ASTBuilder.php.

I never really worked with subscriptions and do not plan to work on it myself, but I am open for pull requests.

Thank you for your contribution. You have a totally valid use case. Powering up `@inject` in the way you described seems reasonable, i would be willing to incorporate a PR...