Benedikt Franke

Hi @Warxcell, I checked out the PR and took the liberty of making a few changes. In https://github.com/webonyx/graphql-php/pull/1263 I was able to make the breaking change to the interface obsolete....

I actually think that `@rename` is still being executed, but i see how it might not have the desired effect. Can you share an example or a failing test case...

I guess the following call is repeated: https://github.com/webonyx/graphql-php/blob/aa7d23a598a1a5433a66f1144a9e5ba9c7ae0f7e/src/Validator/Rules/QueryComplexity.php#L123 Perhaps we can apply memoization in the implementation of the `QueryComplexity` rule?

@thekonz I included the parts that clean up existing code in https://github.com/nuwave/lighthouse/pull/2390.

I cleaned up a couple of remaining places where the interface could be used and added another change on top. It is somewhat unrelated but touches the same parts of...

> i don't understand why my change would make codecov care all of a sudden. No worries, we can just ignore that. > what's your merge strategy? merge v7 changes...

Please put this error message in a gist and remove the comment, it is way too long.

Please extend `testDefaultResolverGrabsValuesOffOfCommonPhpDataStructures`.

I think this could be fixed by returning the response for both `AuditOk` and `AuditFail`.

My instinct says that the additional check for whichever setting controls this behaviour might eat up some of the benefits afforded by it. Making this as fast as possible would...