Benedikt Franke

Results 451 comments of Benedikt Franke

> @spawnia what about using assert(is_iterable()) (it won't be executed on production, hence the optimization) ? I don't want to change the default behaviour of this library in production settings....

I am guessing we need to leverage introspection to add the public properties to `$parametersArray` in this code segment? https://github.com/TomasVotruba/bladestan/blob/1151c7092e1b9077cb8c4f2a4ca2df1c974bf89d/src/NodeAnalyzer/BladeViewMethodsMatcher.php#L80-L99

Hi @ondrejmirtes, I have prepared an example here: https://phpstan.org/r/9211531e-e8a5-4877-9696-07b2d7f28aa0 Since PHP is a language with first-class functions, I would argue it should be possible to fully type those functions when...

> @spawnia PHPStan can already figure this out if you pass the closure directly to the callable parameter: [phpstan.org/r/41d3577a-cb15-406a-86bc-f9bb2d5269b3](https://phpstan.org/r/41d3577a-cb15-406a-86bc-f9bb2d5269b3) That's cool, I have also been pleasently surprised by the strong...

Seconded, I can't see how I would achieve what I do in the following code easily. It would require way more complexity, passing around the namespace with the `ClassType` object...

For anyone who might find this issue later, the test/audit suite is developed at https://github.com/graphql/graphql-http.

I think we should keep `query` required for the standard `GraphQL-over-HTTP request` that every compliant `MUST` support. Making it optional forces the server to implement alternatives. It does not really...

@benjie I have added the described test case in https://github.com/webonyx/graphql-php/pull/1303. Constructing the schema from your example SDL worked fine, it did correctly not support mutations. I had to make the...

Lighthouse leverages [Laravel's rate limiting](https://laravel.com/docs/rate-limiting), which is rather simplistic in its implementation. I could see adding additional structured data to rate limit errors as described in https://docs.github.com/en/graphql/overview/resource-limitations#rate-limit, but am unsure...