efcore.pg icon indicating copy to clipboard operation
efcore.pg copied to clipboard

Remove reference to EF-internal TpcTablesExpression

Open roji opened this issue 3 years ago • 2 comments
trafficstars

In #2366, I added NpgsqlSetOperationTypeResolutionCompensatingExpressionVisitor, which adds an explicit convert node on the leftmost set operation operand, to work around problematic PG type inference behavior.

At the moment, this visitor needs to visit the EF-internal TpcTablesExpression. @smitpatel will be looking at changes on the EF side to obviate this. This is non-critical.

roji avatar May 29 '22 09:05 roji

I am already working on this. Many edge cases but it will be done in 7.0

smitpatel avatar May 29 '22 16:05 smitpatel

Thanks @smitpatel, no rush as I said, I have no problem even shipping like this.

roji avatar May 29 '22 18:05 roji

This was done.

roji avatar Oct 15 '22 11:10 roji